[Mesa-users] Some routines in run_star_extras not called during binary evolution

[Evan Bauer]

Hi Jeremy,

Thanks for the report, and sorry it took us so long to get back to you on this one.

It does indeed seem to be the case that binary does not call extras_start_step in r12778. Pablo Marchant recently explained to me that extras_start_step was added to star somewhat after the binary module was developed, which is probably the reason that it didn't get fully integrated into binary for a while.

Happily, Matthias Fabry has done some more recent updates to the binary module so that it does now incorporate the extras_start_step routines (https://github.com/MESAHub/mesa/pull/459 <https://github.com/MESAHub/mesa/pull/459>), so this appears to be all patched up as of the latest MESA release version (r23.05.1).

For older versions such as r12778, you should hopefully be able to use extras_binary_start_step in run_binary_extras to achieve the same goals you might have intended to use extras_start_step for. Is that a sufficient workaround for you?

Cheers,
Evan

> On Jan 9, 2024, at 3:23 PM, Jeremy Sakstein via Mesa-users <mesa-users at lists.mesastar.org> wrote:
> 
> Hi everyone,
> 
> I am trying to add some modifications to the run_star_extars in the binary module in mesa-r12778 and it appears to me that some functions are not being called. Specifically, it looks to me like extras_start_step and extras_after_evolve are not being called.
> 
> To test this, I wrote write(*,*) statements into each routine but the print statements for extras_start_step and extras_after_evolve but they did not display on the terminal. I did the same for extras_controls and extras_finish_step and these did write to the terminal.
> 
> To test this further I added a global integer that is set to zero in extras_controls, set to 1 in extras_start_step, and written to the terminal in extras_finish_step. The write statement gives zero, indicating that extars_start_step is not being called.
> 
> I am attaching a simple run_star_extras that can be used to reproduce this. It is a modified version of the version found in the 'evolve_both_stars' test_suite. I checked for 'star_plus_point_mass' and it also seems to be the case that these routines are not being called.
> 
> Am I correct that they are not being called and, if so, is there a way of calling them?
> 
> Cheers,
> 
> Jeremy
> 
> 
> -- 
> Jeremy Sakstein (He/Him/His)
> Assistant Professor of Theoretical Physics
> Department of Physics & Astronomy
> University of Hawaiʻi at Mānoa
> Watanabe Hall
> 2505 Correa Road
> Honolulu, HI, 96822, USA
> http://www.jeremysakstein.com <http://www.jeremysakstein.com/>
> <run_star_extras.f>_______________________________________________
> mesa-users at lists.mesastar.org
> https://lists.mesastar.org/mailman/listinfo/mesa-users
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.mesastar.org/pipermail/mesa-users/attachments/20240123/f84d9174/attachment.htm>