[Mesa-users] PPISN with hydrogen envelope

[Rob Farmer]

Hi Mairead,

When moving between versions I would recommend starting from the 15140
version and adding back what you need from your 10108 version rather than
trying to upgrade the 10108 files to 15140. That way you get less issues
when things change, like the removal of those eps_grav terms.

But I would highly recommend simply starting from 15140, as other options
will have been added/removed and it would be better to start from 15140.

Rob

On Fri, 26 Nov 2021 at 09:40, Warrick Ball via Mesa-users <
mesa-users at lists.mesastar.org> wrote:

> Hi Mairead,
>
> Quite a lot changed between r10398 and r15140, so I'm not surprised that a
> `run_star_extras.f90` produces compile-time errors.
>
> I can't comment on the changes to `eps_grav` but I can remark on the
> change from e.g. `xtra1` to `xtra(1)`.  The relevant changes were made in
> r12115 and described in the release email (but don't appear on the new docs
> site):
>
>
> https://lists.mesastar.org/pipermail/mesa-users/2019-September/010470.html
>
> In short, the `xtra1`, `xtra2`, etc were bundled into arrays.  All you
> should need to do is change any occurrences of `xtraN` to `xtra(N)`, for
> each integer `N`.  Although `ppisn` defines integers with names to make
> these meaningful, the arrays are fundamentally being indexed with
> integers.  It's just handy to give them useful names.
>
> But *do* make sure that your indices aren't colliding. i.e. you aren't
> accidentally trying to use `xtra(3)` and `xtra(convenient_name)` where
> `convenient_name` is actually 3.  I'd suggest avoiding this by either only
> using named integers or only using pure numbers and not mixing the two.
>
> Hope that helps!
>
> Cheers,
> Warrick
>
> ___________
>
> Warrick Ball
> Postdoc, School of Physics and Astronomy
> University of Birmingham, Edgbaston, Birmingham B15 2TT
> W.H.Ball at bham.ac.uk
> +44 (0)121 414 4552
>
> On Fri, 26 Nov 2021, mesa-users at lists.mesastar.org wrote:
>
> > Hello!
> >
> > I'm a grad student at the University of Toronto working with Chris
> Matzner on pair instability pulsations in stars with envelopes. I'm trying
> to evolve a PPISN with a hydrogen envelope in r15140 using the 2018
> instrument paper inlists (r10108). I've
> > also been looking at the test suite as a reference. I've updated the
> inlists and run_star_extras file to be compatible with r15140, as far as I
> can tell. However, it fails to compile with the error "___ at (1) is not a
> member of the 'star_info'
> > structure; did you mean '____'?" due to two eps_grav related variables
> (eps_grav_dt_term_const_q and eps_grav_dm_term_const_q) and lxtra, xtra,
> and ixtra variables. Were these changed between r10108 and r15140, and if
> so, how? Or is there something
> > else I might be missing? I know there were changes to eps_grav, but I'm
> not sure what is necessary to apply here.
> >
> > Also, the test suite defines the indices of the lxtra variables
> (ex. lxtra(lx_hydro_on) ) at the beginning of run_star_extras; the
> instrument paper inlist doesn't and just uses them as lxtra1, lxtra2,
> etc. I didn't find other examples of
> > lxtra/xtra/ixtra variables in use outside of the PPISN test suite, so
> I'm not sure if the difference is due to a change in MESA or if it's a
> regular difference in how they're written.
> >
> > The inlists and run_star_extras file that I'm using are attached, and a
> printout of the error is below.
> >
> > Thank you very much in advance for your help!
> >
> > Best,
> > Mairead Heiger
> > PhD Student, Astronomy and Astrophysics
> > University of Toronto
> >
> >
> > ../src/run_star_extras.f90:95:37:
> >    95 |          s% eps_grav_dm_term_const_q(k) = 0d0
> >       |                                     1
> > Error: 'eps_grav_dm_term_const_q' at (1) is not a member of the
> 'star_info' structure; did you mean 'd_eps_grav_dlnpgasm1_const_t'?
> > ../src/run_star_extras.f90:96:37:
> >
> >    96 |          s% eps_grav_dt_term_const_q(k) = 0d0
> >       |                                     1
> > Error: 'eps_grav_dt_term_const_q' at (1) is not a member of the
> 'star_info' structure; did you mean 'd_eps_grav_dlnpgasm1_const_t'?
> > ../src/run_star_extras.f90:261:24:
> >
> >   261 |          extras_startup = 0
> >       |                        1
> > Error: Symbol 'extras_startup' at (1) has already been host associated
> > ../src/run_star_extras.f90:266:22:
> >
> >   266 |             s% lxtra1 = .false.
> >       |                      1
> > Error: 'lxtra1' at (1) is not a member of the 'star_info' structure; did
> you mean 'lxtra'?
> > ../src/run_star_extras.f90:268:22:
> >
> >   268 |             s% lxtra2 = .false.
> >       |                      1
> > Error: 'lxtra2' at (1) is not a member of the 'star_info' structure; did
> you mean 'lxtra'?
> > ../src/run_star_extras.f90:270:22:
> >
> >   270 |             s% lxtra3 = .false.
> >       |                      1
> > Error: 'lxtra3' at (1) is not a member of the 'star_info' structure; did
> you mean 'lxtra'?
> > ../src/run_star_extras.f90:272:21:
> >
> >   272 |             s% xtra1 = -1d0
> >       |                     1
> > Error: 'xtra1' at (1) is not a member of the 'star_info' structure; did
> you mean 'xtra'?
> > compilation terminated due to -fmax-errors=7.
> > make: *** [run_star_extras.o] Error 1
> >
> >
> >
> _______________________________________________
> mesa-users at lists.mesastar.org
> https://lists.mesastar.org/mailman/listinfo/mesa-users
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.mesastar.org/pipermail/mesa-users/attachments/20211126/3bc14dd4/attachment.htm>