[Mesa-users] Question about the PPISN test suite

[Rob Farmer]

Hi,
The implications are what is stated in the comments, this allows larger
timesteps during core he burning. You should run your own tests to see if
this makes a difference for your results (there are many ways to get longer
timesteps during the evolution, some are more useful than others).

The test suite isn't designed to give the most physical results possible,
simply something reasonable within a limited amount of runtime (so that we
can run the tests quickly).

This goes for all test cases, they should only be a starting point as you
need to experiment yourself with the options and controls it uses to decide
which options work/don't work for your science case.

Rob


On Thu, 2 Jul 2020 at 00:56, Jeremy Sakstein <sakstein at hawaii.edu> wrote:

> Hi everyone,
>
> I have a question about the PPISN test suite. I was looking at
> run_star_extras.f and found the following lines:
>
>          ! Ignore energy checks before first time hydro is turned on
>          ! otherwise need small steps during core helium burning and it
>          ! slows down the test_suite
>          if (.not. s% lxtra(lx_hydro_has_been_on)) then
>             s% cumulative_work_outward_at_surface = 0d0
>             s% cumulative_work_inward_at_center = 0d0
>             s% cumulative_eps_grav = 0d0
>             s% cumulative_delta_total_energy = 0d0
>             s% cumulative_energy_error = 0d0
>             s% cumulative_L_center = 0d0
>             s% cumulative_L_surf = 0d0
>             s% cumulative_extra_heating = 0d0
>             s% cumulative_irradiation_heating = 0d0
>             s% cumulative_Ne22_sedimentation_heating = 0d0
>             s% cumulative_nuclear_heating = 0d0
>             s% cumulative_non_nuc_neu_cooling = 0d0
>             s% cumulative_sources_and_sinks = 0d0
>             write(*,*) &
>                "Setting energy conservation error to zero until hydro is
> turned on for the first time"
>          end if
>
> From what I can tell, this is essentially turning energy conservation
> checks off. I wanted to know what the implications of this are?
>
> Would one expect dramatically different results e.g. final black hole
> mass, mass at helium depletion if one were to comment these lines out?
>
> Cheers,
>
> Jeremy
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.mesastar.org/pipermail/mesa-users/attachments/20200703/224566d5/attachment.htm>