[Mesa-users] other_wind
Warrick Ball
W.H.Ball at bham.ac.uk
Mon Oct 21 05:31:35 EDT 2019
Hi Croxmor,
In Fortran, variables must be declared before any actual code. Your
`run_star_extras.f` has a mixture. So the first thing is to move all of
the variable declarations before any code. That is, all the lines like
`real(dp) ...`, `integer ...` etc have to come before calculations or
assignments (like `ierr = 0` or `call star_ptr...` etc).
I expect you'll then run into a few other errors because your extra wind
routine has diverged from the template bundled with r11701. First, you've
added the extra input integer `id_extra`, which shouldn't be there (and
isn't used anyway). Second, you've dropped the `intent(out)` attribute
from `ierr`.
If you fix these, the code should compile.
Cheers,
Warrick
------------
Warrick Ball
Postdoc, School of Physics and Astronomy
University of Birmingham, Edgbaston, Birmingham B15 2TT
W.H.Ball at bham.ac.uk
+44 (0)121 414 4552
On Sun, 20 Oct 2019, mesa-users at lists.mesastar.org wrote:
> You are right, here is the actual version of the run_star_extras.f and the message printed by the terminal is:
> gfortran -Wno-uninitialized -fno-range-check -fmax-errors=7 -fprotect-parens -fno-sign-zero -fbacktrace -ggdb -finit-real=snan -fopenmp -fbounds-check -Wuninitialized -Warray-bounds -ggdb -ffree-form -x
> f95-cpp-input -I/home/rodrigo/mesa-r11701/include -I/home/rodrigo/mesasdk/include -c ../src/run_star_extras.f
> ../src/run_star_extras.f:79:82:
>
> real(dp), intent(in) :: Lsurf, Msurf, Rsurf, Tsurf ! surface values (cgs)
> 1
> Error: Unexpected data declaration statement at (1)
> ../src/run_star_extras.f:86:73:
>
> hot_wind, cool_wind, H_env_mass, H_He_env_mass, He_layer_mass
> 1
> Error: Unexpected data declaration statement at (1)
> ../src/run_star_extras.f:87:44:
>
> logical, parameter :: dbg = .false.
> 1
> Error: Unexpected data declaration statement at (1)
> ../src/run_star_extras.f:88:85:
>
> character (len=strlen) :: message, cool_wind_scheme, hot_wind_scheme, scheme
> 1
> Error: Unexpected data declaration statement at (1)
> ../src/run_star_extras.f:89:67:
>
> logical :: is_infalling, using_wind_scheme_mdot, use_other
> 1
> Error: Unexpected data declaration statement at (1)
> ../src/run_star_extras.f:90:73:
>
> real(dp), parameter :: Zsolar = 0.019d0 ! for Vink et al formula
> 1
> Error: Unexpected data declaration statement at (1)
> ../src/run_star_extras.f:92:80:
>
> real(dp), intent(out) :: w ! wind in units of Msun/year (value is >= 0)
> 1
> Error: Unexpected data declaration statement at (1)
> compilation terminated due to -fmax-errors=7.
> make: *** [/home/rodrigo/mesa-r11701/star/work_standard_makefile:38: run_star_extras.o] Error 1
>
> FAILED
>
> El dom., 20 oct. 2019 a las 9:44, Aaron Dotter (<aaron.dotter at gmail.com>) escribió:
> In order to help you we will need the code that gives the error message, not just the error message.
>
> Also please copy and paste the text from the terminal into your email rather than sending a screenshot.
>
>
>
> On Sat, Oct 19, 2019 at 10:00 PM Croxmor Moraga <rodrigo.moraga.merino at gmail.com> wrote:
> I included the command you gave me, but that only gave me another compilation error, the error now appears when I declare other variables I use: as it can be seen here:
> Do I have to change the declarations that I was using until now, or don't use it at all?
> Thanks for your consideration.
>
> El sáb., 19 oct. 2019 a las 22:06, Croxmor Moraga (<rodrigo.moraga.merino at gmail.com>) escribió:
> Thanks, I'll check it out. The idea is that loggsol is a constant defined in const.f90
>
> El jue., 17 oct. 2019 a las 16:42, Aaron Dotter (<aaron.dotter at gmail.com>) escribió:
> In order to access variables stored in the star derived type (s), you have to do this:
> call star_ptr(id, s, ierr)
>
> at the top of your other_ routine. See
>
> http://mesa.sourceforge.net/run_star_extras.html#activate-run_star_extrasf
>
> for more information about how to do this. I would also point out that I couldn't find anywhere that you set a value to "loggsol" so it's being used without being set.
>
>
> Aaron
>
>
> On Thu, Oct 17, 2019 at 3:37 PM Croxmor Moraga <rodrigo.moraga.merino at gmail.com> wrote:
> Here it is. My bad.
>
> El jue., 17 oct. 2019 a las 16:33, Aaron Dotter (<aaron.dotter at gmail.com>) escribió:
> (I have attached my run_star_extras.f and the inlist mentioned before. On MESA version: )
>
>
> There is no run_star_extras.f attached.
>
>
>
>
> El mié., 16 oct. 2019 a las 0:01, Josiah Schwab (<jwschwab at ucsc.edu>) escribió:
> Hi Croxmor,
>
> > But when I saw the other_wind.f90 code file, it didn't give me an example
> > of how to add a new wind scheme to the cool_wind_rgb; the only thing I want
> > to do, is to replace the original wind equation of one of the default
> > schemes, and use another version of that one.
> > So my problem is, from all the different routines and subroutines defined
> > en wind.f90; which one should I take and put in my run_star_extra file as a
> > subroutine?
> > When I only want to add a new scheme for the cool_wind_rgb without changing
> > anything else?
> > Here I attached the wind.f90 file for faster revision.
>
> I believe you can provide your other routine in run_star_extras and then set
>
> cool_wind_RGB_scheme = 'other'
>
> to only apply it in that case.
>
> Josiah
>
> _______________________________________________
> mesa-users at lists.mesastar.org
> https://lists.mesastar.org/mailman/listinfo/mesa-users
>
>
>
More information about the Mesa-users
mailing list