[mesa-users] Bug in MLT?

[Bill Paxton]

Hi Jim,

Thanks for the report.  That part of the code has been reworked since the 8845 release, and it currently is doing something that I believe is equivalent to what you suggest.  The best way to determine if this is actually the case would be for you to try running your test with a pre-release version -- e.g., 9158.  Or, alternatively, take a look at the current mlt_info.f90 (attached; see section starting at line 308).

Cheers,
Bill

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mlt_info.f90
Type: application/octet-stream
Size: 63381 bytes
Desc: not available
URL: <https://lists.mesastar.org/pipermail/mesa-users/attachments/20160913/f93ba7ce/attachment.obj>
-------------- next part --------------




On Sep 13, 2016, at 4:16 PM, Jim Fuller wrote:

> Hi all,
> 
> I may have found a bug in MLT, or maybe I just don't understand how the code works. I am using mesa8845. In star/private/mlt_info.f90, there is a statement:
> 
>          if (s% v_flag) then
>             if (s% v(k) > s% csound_face(k)) cv_old = 0d0
>          end if
> 
> However, I think this should say something like 
> 
>          if (s% v_flag) then
>             if (s% v(k)/s% csound_face(k) > s% max_v_div_cs_for_convection) cv_old = 0d0
>          end if
> 
> Am I wrong? I find artificial jumps in convection velocities in regions with large velocities if use the upper statement, but the bottom statement appears to fix it. Any feedback would be helpful. Best,
> 
> -Jim
> ------------------------------------------------------------------------------
> _______________________________________________
> mesa-users mailing list
> mesa-users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mesa-users