[mesa-users] Small bug in the one zone burner?

[Ken Shen]

Hi all, I think I've found a minor bug in the one zone burner that makes up
the net test directory.  I don't think it concerns the vast majority of
you...

In mod_one_zone_burn.f, the subroutine burn_solout1 prints out some stuff
to look at while the one zone burn is going.  It uses the mass fraction
array "x" and computes things like composition info, eos calls, etc.
However, when called by burn_finish_substep, I think burn_solout1 is
actually getting passed a number abundance array "y" (as in x_i = y_i*A_i,
where A is the molecular weight).  That's because burn_finish_substep is
called by net_1_zone_burn and burn_1_zone via burner_finish_substep, and
that interface asks for "y", not "x".

When I sum "x" from within burn_solout1, I definitely don't get 1.  And the
abundances all seem to be the number abundances, as far as I can tell.

Also, I don't think this problem exists with the constant pressure burn
flag on because that burner passes along "x", not "y".

Anyone want to verify?


Thanks,
Ken
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.mesastar.org/pipermail/mesa-users/attachments/20150710/585070d5/attachment.html>