[mesa-users] other_cgrav

[Jeremy Sakstein]

Just a follow-up question for this.

I use other_cgrav a lot and I didn't realise that it wasn't used here. Are
rotational corrections to the SS equations turned on by default or is there
a control you need to change in order for this to apply? I've been looking
through the code and I can't figure it out. From what I can
tell, use_dP_dm_rotation_correction = .true. so this is turned on by
default but I don't know if there is a separate flag that turns rotation on
all together --- I never use it.

Cheers,

Jeremy



On 18 August 2015 at 17:27, Bill Paxton <paxton at kitp.ucsb.edu> wrote:

> Hi Matthew,
>
> I'll be happy to help.  Glad you caught it.   As you probably noticed,
> this particular chunk of code was imported into mesa/star from a
> contribution from Evert Glebbeek that was in turn based on code from Alex
> Heger which was based on the work of Endal & Sofia --- I got it working but
> didn't do the additional step of allowing for G to be a function of the
> location in the star -- somehow Evert and others had skipped that feature!
>  ;D    Various technical changes in the implementations of gfortran and
> ifort have now made it much easier to make this change in the mesa code,
> so, prompted by your request, here is a modified for hydro_rotation for you
> to try.
>
>
>
> Concerning other possible places where s% cgrav should be used but isn't,
> use grep to check for "standard_cgrav".  When I do that, I don't see any
> unreasonable cases other than the one you have discovered.
>
> Please check my changes carefully and let me know if it seems to be okay.
>
> Thanks,
> Bill
>
>
>
>
>
>
> On Aug 18, 2015, at 8:16 AM, Matthew Clayton wrote:
>
> Hi there,
>
> I'm doing some simulations that make use of the other_cgrav hook to
> replace G with a vector of user-defined values. It has been pointed out to
> me that this hook isn't actually properly implemented throughout the code
> -- in particular hydro_rotation.f90 has the amusing comment:
>
>       ! NOTE: we are not using the user supplied cgrav vector here.
>       ! that can (should) be changed (if anyone cares).
>
> Realising that I may well be the only person that cares about this hook, I
> have attempted to naively correct things by replacing all occurrences of
> standard_cgrav with the appropriate element of the s%cgrav vector, but that
> seems to throw up dependency problems with getting the star_info structure.
> Perhaps someone with more knowledge of the architecture of MESA/star could
> give me a hand fixing this?
>
> Also if anyone happens to know any other places that s%cgrav isn't
> implemented that would be useful to know too.
>
> Cheers,
>
> Matthew
>
> ------------------------------------------------------------------------------
> _______________________________________________
> mesa-users mailing list
> mesa-users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mesa-users
>
>
>
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> mesa-users mailing list
> mesa-users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mesa-users
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.mesastar.org/pipermail/mesa-users/attachments/20150818/4e6cb662/attachment.html>