[mesa-users] other_cgrav

[Bill Paxton]

Hi Matthew,

I'll be happy to help.  Glad you caught it.   As you probably noticed, this particular chunk of code was imported into mesa/star from a contribution from Evert Glebbeek that was in turn based on code from Alex Heger which was based on the work of Endal & Sofia --- I got it working but didn't do the additional step of allowing for G to be a function of the location in the star -- somehow Evert and others had skipped that feature!  ;D    Various technical changes in the implementations of gfortran and ifort have now made it much easier to make this change in the mesa code, so, prompted by your request, here is a modified for hydro_rotation for you to try.



Concerning other possible places where s% cgrav should be used but isn't, use grep to check for "standard_cgrav".  When I do that, I don't see any unreasonable cases other than the one you have discovered.

Please check my changes carefully and let me know if it seems to be okay.

Thanks,
Bill






On Aug 18, 2015, at 8:16 AM, Matthew Clayton wrote:

> Hi there,
> 
> I'm doing some simulations that make use of the other_cgrav hook to replace G with a vector of user-defined values. It has been pointed out to me that this hook isn't actually properly implemented throughout the code -- in particular hydro_rotation.f90 has the amusing comment:
> 
>       ! NOTE: we are not using the user supplied cgrav vector here.
>       ! that can (should) be changed (if anyone cares).
> 
> Realising that I may well be the only person that cares about this hook, I have attempted to naively correct things by replacing all occurrences of standard_cgrav with the appropriate element of the s%cgrav vector, but that seems to throw up dependency problems with getting the star_info structure. Perhaps someone with more knowledge of the architecture of MESA/star could give me a hand fixing this?
> 
> Also if anyone happens to know any other places that s%cgrav isn't implemented that would be useful to know too.
> 
> Cheers,
> 
> Matthew
> ------------------------------------------------------------------------------
> _______________________________________________
> mesa-users mailing list
> mesa-users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mesa-users

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.mesastar.org/pipermail/mesa-users/attachments/20150818/7c0d4b19/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hydro_rotation.f90
Type: application/octet-stream
Size: 22623 bytes
Desc: not available
URL: <https://lists.mesastar.org/pipermail/mesa-users/attachments/20150818/7c0d4b19/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.mesastar.org/pipermail/mesa-users/attachments/20150818/7c0d4b19/attachment-0001.html>