[mesa-users] Problems with xtra data

[Bill Paxton]

Hi Pablo,

On Dec 4, 2012, at 9:04 AM, Pablo Marchant wrote:

> I've been trying to fix some issues with the binary evolution implementation of MESA, and noticed that backups are causing strange hiccups in some of my test runs. The issue is that the binary system information is stored in the xtra variables of the star_info, and these are not properly regressed after a backup, although on star_def.inc it is commented that:
> 
> "
> ! more extras -- for run_star_extras applications with state.
> ! if your extra state info is all held in the following variables,
> ! restarts, retries, and backups will work without doing anything special.
> "

the comments are ahead of the code.   the code currently only takes care of restarts from photos.

> 
> I checked the set_current_to_old subroutine, and effectively there is no mention to the xtra variables. Also, I guess one would require a whole host of xtra_old and xtra_older for this to be done. Should this actually be part of the backup process, or is there a reason why it's not done?

you have it exactly right.   and it hasn't been done simply because no one has asked before.
if you'd like to fix that, please go ahead and then send me the edits.  

> 
> PD: the set_current_to_old subroutine also has a bug, the last line reads
> "
> s% err_ratio_avg_hydro = s% err_ratio_avg_hydro
> "
> which should be replaced with
> "
> s% err_ratio_avg_hydro = s% err_ratio_avg_hydro_old
> "
> 

fixed now.  thanks for pointing it out.

Cheers,
Bill